EO learn instance_id deprecation warning

barrett · May 5, 2020, 5:46pm

Hi,
With the latest versions of eo-learn and sentinelhub-py when I use eo-learn to download Sentinel data (e.g. using S2L1CWCSInput), I get the deprecation warning from here:

github.com

sentinel-hub/sentinelhub-py/blob/b9666c90263eb6407c6a2e2145da2eb4434a98ae/sentinelhub/data_request.py#L46


    :param data_folder: location of the directory where the fetched data will be saved.
    :type data_folder: str
    :param config: A custom instance of config class to override parameters from the saved configuration.
    :type config: SHConfig or None
    """
    self.download_client_class = download_client_class
    self.data_folder = data_folder
    self.config = config or SHConfig()


    if instance_id is not None:
        warnings.warn("Parameter 'instance_id' is deprecated and will soon removed. Use parameter 'config' instead",
                      category=SHDeprecationWarning)
        self.config.instance_id = instance_id


    self.download_list = []
    self.folder_list = []
    self.create_request()


@abstractmethod
def create_request(self):
    """ An abstract method for logic of creating download requests

But if I pass the suggested “config” parameter instead, I get:
TypeError: init() got an unexpected keyword argument ‘config’

I guess even though instance_id is deprecated in sentinelhub-py, the replacement config parameter is not yet supported by eo-learn?

batic · May 6, 2020, 2:11pm

Hi @barrett,

You are right. The deprecation is there to let users know it will be removed some time in the future. Unfortunately, eo-learn is not yet completely compliant, hence this discrepancy.

In any case, at the moment it is just a warning. We’ll be updating eo-learn in near future.

Best,
Matej