isCloud function return value in example scripts

I am a bit confused about function isClouds provided in the example script on following links:

The function is:

function isCloud (scl) {
  if ([1, 2, 7, 8, 9, 10, 11].includes(scl))  {
    return false;
  }

As by the function name I would say that it should return true if there is cloud and false if there is no cloud. But as I understand it actually just returns false if there is cloud (of course values 1,2,11 add here saturated defective, dark shadow and snow&ice).
So looking just at the function, i would say it should be

function isCloud (scl) {
  if ([1, 2, 7, 8, 9, 10, 11].includes(scl))  {
    return true;
  }

On the other hand, isCloud is used in scope of using eobrowserStats. So maybe it is necessary that isCloud function returns false, so eobrowserStats works accordingly with masking?
eobrowserStats: [indexVal,cloud?1:0]
Also I am not sure for second input for eobrowserStats: which value will filter scene by cloud coverage: 1 or 0? Not really clear from description in

But from testing in OE Browser, it seems value 1
eobrowserStats: [indexVal,1]
would filter everything out. If that is true, I think isCloud function should be changed.

Similar isCloud function is done here

where actually it returns true in case of clouds.

Hi @mohito ,

Thank you for reporting this. You’re right the isCloud should return true and it is fixed now.

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.